Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed code transferred to GPURigidRegistrationLib and fetch the code from GitHub instead #456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed code transferred to GPURigidRegistrationLib and fetch the code from GitHub instead #456

wants to merge 2 commits into from

Conversation

drouin-simon
Copy link
Member

No description provided.

hgueziri
hgueziri reviewed Jan 19, 2022
View reviewed changes
IbisPlugins/GPU_RigidRegistration/CMakeLists.txt Outdated
Comment on lines 34 to 37
FetchContent_Declare(
GPURigidRegistrationLib
GIT_REPOSITORY https://github.com/IbisNeuronav/GPURigidRegistrationLib.git
GIT_TAG main )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the binary directory is ${CMAKE_BINARY_DIR}/_deps, I added the following lines to make it more consistent with other dependencies:

set(FETCHCONTENT_BASE_DIR ${IBIS_EXTERNAL_DEPENDENCIES_DIR}/GPUReg CACHE PATH "Directory under which to collect all populated content" FORCE)

FetchContent_Declare(
  GPURigidRegistrationLib
  GIT_REPOSITORY https://github.com/IbisNeuronav/GPURigidRegistrationLib.git
  GIT_TAG main 
  SOURCE_DIR ${FETCHCONTENT_BASE_DIR}/src
  BINARY_DIR ${FETCHCONTENT_BASE_DIR}/build
  SUBBUILD_DIR ${FETCHCONTENT_BASE_DIR}/subbuild
  )

@hgueziri
Copy link
Member

I reduced path names to ${IBIS_EXTERNAL_DEPENDENCIES_DIR}/GPUReg, still does not compile on windows with the following error message:

2>------ Build started: Project: ibis, Configuration: Release x64 ------
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1941,5): warning MSB6002: The command-line for the "RC" task is too long. Command-lines longer than 32000 characters are likely to fail. Try reducing the length of the command-line by breaking down the call to "RC" into multiple calls with fewer parameters per call.
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1941,5): error MSB6003: The specified task executable "rc.exe" could not be run. System.ComponentModel.Win32Exception (0x80004005): The filename or extension is too long
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1941,5): error MSB6003:    at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1941,5): error MSB6003:    at System.Diagnostics.Process.Start()
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1941,5): error MSB6003:    at Microsoft.Build.Utilities.ToolTask.ExecuteTool(String pathToTool, String responseFileCommands, String commandLineCommands)
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1941,5): error MSB6003:    at Microsoft.Build.CPPTasks.TrackedVCToolTask.TrackerExecuteTool(String pathToTool, String responseFileCommands, String commandLineCommands)
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1941,5): error MSB6003:    at Microsoft.Build.CPPTasks.TrackedVCToolTask.ExecuteTool(String pathToTool, String responseFileCommands, String commandLineCommands)
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1941,5): error MSB6003:    at Microsoft.Build.Utilities.ToolTask.Execute()
2>Done building project "ibis.vcxproj" -- FAILED.

@nist-anka
Copy link
Contributor

The latest changes in master branch should be applied, otherwise SuperBuild fails.

@errollgarner
Copy link
Contributor

I rebased on latest master, integrated @hgueziri's changes and shortened the path even further (GR instead GPUReg). The path is now short enough to compile when building in the shortest possible base directory (C:\B). This is a bit impractical and inconvenient however. Perhaps we can find another solution?

@hgueziri
Copy link
Member

hgueziri commented Dec 21, 2023 •
edited
Loading

We could also consider to reduce path lengths in https://github.com/hgueziri/GPURigidRegistrationLib repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgueziri hgueziri hgueziri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drouin-simon @hgueziri @nist-anka @errollgarner